The title pretty much says it all here, when you're writing T-SQL, the correct place to place the semicolon (;) is at the end of all you're statements.
Something I see quite often is batches where people don't terminate any of their statements, but do start statements that use a CTE or Merge statement with a semicolon. This means you see syntax like the below:
DECLARE @MyVariable int SET @MyVariable = 5 ;WITH MyCTE AS( SELECT *, ROW_NUMBER() OVER (PARTITION BY CONVERT(date,MyDate) ORDER BY MyDate DESC) AS RN FROM MyTable WHERE MyColumn = @MyVariable) SELECT * FROM MyCTE WHERE RN = 1
There are several problems, in my opinion, about not correctly terminating your statements, but also beginning statements with a semicolon that require the previous statement to be properly terminated.
Firstly, not terminating your statements is a deprecated feature in SQL Server. This means that should you have SQL that isn't properly terminated, and Microsoft do (eventually) remove the functionality of not terminating your statements, then your query will fail. There is no alternative to this, Microsoft only offers one solution: "End Transact-SQL statements with a semicolon ( ; )."
The likely reason that this is deprecated isn't because the parser is being "less" clever but that T-SQL is becoming more complex. The
WITH keyword can appear in several places and has different meanings. For example it's used at the start of a statement to denote that a CTE is being declared. It can be used at the end of a DDL statement to specify that versioning is enabled, the type of compression or if the table is memory optimised. It's also used for query hints when referencing a table (most commonly seen when people are abusing the
NOLOCK hint). In all these cases,
WITH has a different meaning, and the parser needs to be able to know which one it has. As a result, if the first "word" in the statement is
WITH, then SQL Server knows that it's the declaration of a CTE; but to safely know it's the first word in the statement you need to tell SQL Server it is, by properly terminating the prior statement.
When you write code, I hope that you properly format it. From the Parser's point of view though, it doesn't "care" about white space and line breaks the same way we do. Take the statements below:
CREATE TABLE dbo.MyTable (ID int, MyColumn varchar(10)) WITH CTE AS( SELECT MAX(ID) FROM dbo.OtherTable) INSERT INTO dbo.MyTable SELECT ID, N'OtherTable' FROM CTE
To us it is easy to see that
WITH is the declaration of a CTE. It's on a separate line, and has a gap between it and the end of the DDL statement. To the parser, however,
WITH is a perfectly acceptable keyword to be placed after
varchar(10)). As a result, without the statement being terminated the
WITH keyword meaning is ambiguous. It's just like if someone gave you the date "03/01/2019". For some of us that would represent the date 03 January 2019 but for others it would be March 01 2019. Unless someone explicitly tells you the format of the date, or uses an unambiguous format (yyyyMMdd or yyyy-MM-ddThh:mm:ss.nnnnnnn) then you don't know what it represents. For the parser, putting the semicolon is your way of unambiguously telling it that
WITH is the first word in the statement so represents the declaration of a CTe.
If you do try to run the above, the
WITH will actually be interpreted as part of the
CREATE TABLE statement, and therefore you'll get the error below:
Msg 102, Level 15, State 1, Line 4
Incorrect syntax near 'CTE'.
If you use
WITH as part of a DDL statement, the first thing expected afterwards is a left parenthesis, so having
CTE makes no sense to the parser. The more common error you see, however, when you forget to properly terminate your statement is very explicit on what you need to do:
Incorrect syntax near the keyword 'with'. If this statement is a common table expression, an xmlnamespaces clause or a change tracking context clause, the previous statement must be terminated with a semicolon.
To be just that little be explicit though, notice it states "the previous statement must be terminated with a semicolon". It doesn't say the "statement must be started with a semicolon". This is very much telling you that you need to put the semicolon at the end of the last statement, not at the start of the one that begins with
Using a semicolon at the start of a statement also teaches some bad habits. Unlike other RDBMS, SQL Server does not support the declaration of a CTE inside the statement (i.e. like PostgreSQL). This does not mean, however, that I haven't (often) seen people write statements that look like this (I am not suggesting that this syntax would even be roughly correct in PostgreSQL):
SELECT * FROM ( ;WITH CTE AS( SELECT *, ROW_NUMBER() OVER (PARTITION BY ID ORDER BY MyDate DESC) AS RN FROM MyTable) SELECT * FROM CTE WHERE RN = 1) MT JOIN dbo.OtherTable OT ON MT.ID = OT.ParentID
To those of us that know T-SQL, you can see multiple multiple problems here, however, the one I want to draw attention to is the use of the semicolon in the middle of the statement. A semicolon is a statement terminator, which means that in reality you have 2 statements there. One that ends with
FROM ( and another that begins with
WITH CTE AS. To those of us that know T-SQL well, we know that both
WITH (when declaring a CTE) don't go in the middle of a statement, however, to those that are starting with the language, they don't know that. Having statements that start with
;WITH can make them think that it's not
WITH that's the keyword but that it's
Another scenario where starting a CTE with a
; won't work is when writing a
VIEW or inline table value
FUNCTION when you want to define a CTE. For example, take this simple
VIEW that uses an rCTE to create the numbers 1-100 (don't do this, use a Tally), but instead try to start the CTE with a
CREATE VIEW dbo.Numbers AS ;WITH rCTE AS( SELECT 1 AS I UNION ALL SELECT 1 + I AS I FROM rCTE WHERE I
This will generate the following error:
Msg 102, Level 15, State 1, Procedure Numbers, Line 2
Incorrect syntax near ';'.
VIEW is made up of a single statement, so there is no prior statement to terminate, and so the "beginingator" has no reason to be there; it actually generates an error as your effectively stating that the statement with the
WITH is the second statement in the
I've even seen someone (though this has only happened once) who had a query that looked like this:
SELECT * FROM dbo.MyTable MT ;WITH (NOLOCK) JOIN dbo.OtherTable OT ;WITH (NOLOCK) ON OT.ID = MT.ID WHERE MT.[Name] = 'Steve'
I appreciate that we all have preferences on how we format our SQL too , and that some prefer to start all their statements with a semicolon instead (Aaron Bertrand for example prefers to do this when posting code for others to copy, to avoid errors from where the prior statement wasn't terminated). Although this does work, to a degree, this will always leave your last statement un-terminated (meaning it could fail in the future) and you have a superfluous
; at the very start of your SQL (as there was no prior statement to be terminated). Taking the time to ensure you terminate all your statements now, at the end, is really important for future proofing, and to aid the parser when it needs it. Don't wait until you have to, take the time to do it as you write your SQL. No, you probably don't need to go through your entire application and correct everything to be properly terminated at the moment, but when you need to change something, make sure you add them then to the SQL you're working with. Then, when eventually the "optionalness" of terminating your statements is removed, at least you've got some of the work already done.
Thanks for the article, Thom. Love to follow this advice. But this still gives an error…
declare @StartingRow int;
declare @EndingRow int;
if @PageSize 0
select @StartingRow = (@PageSize * (@Page – 1));
select @EndingRow = (@StartingRow + @PageSize + 1);
end else begin
set @StartingRow = 0;
set @EndingRow = 999999;
WITH ParentHierarchy ….
Where am I missing a semicolon in the previous TSQL code?
There’s a few errors in there Ned. I assumed that both
intvariables for this. Firstly, in your
IFyou don’t have a boolean expression:
if @PageSize 0 BEGINisn’t valid syntax; perhaps you wanted an
Also (though this might have been WordPress trying to be “clever”), it’s highlighted that
@Page – 1is invalid, as it’s not a
If you fix those errors though, I don’t get an error about “missing semicolon”. db<>fiddle
Thanks for your reply. Yeah, those were both wordpress issues. I fixed the error though by doing this :
DECLARE @StartingRow AS INT;
DECLARE @EndingRow AS INT;
IF @PageSize = 0
SET @PageSize = 10000;
SET @StartingRow = (@PageSize * (@Page – 1));
SET @EndingRow = (@StartingRow + @PageSize + 1);
WITH ParentHierarchy …
I guess the sets aren’t deemed statements like select? Weird but working now…
I neglected to tell you this is in a stored procedure and yes, those variables are INT parameters.
To clarify, I don’t “prefer to start all my statements with a semicolon” – I only start CTEs, specifically, and only in code that I write for mass consumption (blogs and Q & A answers), where it is likely that people will copy *just the CTE* into their own existing code – where there are no statement separators anywhere.
Thanks Aaron; I’ll correct my remark when I get the chance.